Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump preseq #390

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Bump preseq #390

merged 3 commits into from
Jun 28, 2024

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 22, 2024

Updating preseq with upstream changes from #382

@ewels ewels requested a review from a team as a code owner March 22, 2024 09:12
@ewels ewels requested a review from FelixKrueger March 22, 2024 09:12
@ewels ewels mentioned this pull request Mar 22, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 22, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit ce40e8d

+| ✅ 212 tests passed       |+
#| ❔   2 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-06-28 21:12:04

@ewels
Copy link
Member Author

ewels commented Apr 15, 2024

@nf-core-bot fix linting

maxulysse
maxulysse approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG?

maxulysse
maxulysse reviewed May 17, 2024
View reviewed changes
modules/nf-core/preseq/lcextrap/main.nf
@@ -1,9 +1,9 @@
process PRESEQ_LCEXTRAP {
tag "$meta.id"
label 'process_single'
label 'error_ignore'
label 'error_retry'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think error_ignore was a good idea actually

Copy link
Member Author

@ewels ewels May 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check line 24 - if retrying it uses a different flag. That's the main improvement in this module change. It's been set to ignore for years before this.

edmundmiller
edmundmiller approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, gonna update the changelog.

@edmundmiller edmundmiller added this to the 2.7.0 milestone Jun 28, 2024
@edmundmiller edmundmiller merged commit 36f8470 into nf-core:dev Jun 28, 2024
33 checks passed
@ewels ewels deleted the bump-preseq branch July 2, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@edmundmiller edmundmiller edmundmiller approved these changes

@FelixKrueger FelixKrueger Awaiting requested review from FelixKrueger FelixKrueger is a code owner automatically assigned from nf-core/methylseq

Assignees

@ewels ewels

Labels
None yet
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ewels @maxulysse @edmundmiller